Received: from eggs.gnu.org ([2001:4830:134:3::10]:44437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLDqI-0001zp-2s for qemu-devel@nongnu.org; Wed, 05 Mar 2014 10:34:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLDqD-0005Mm-3k for qemu-devel@nongnu.org; Wed, 05 Mar 2014 10:34:46 -0500 Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:55715 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLDqC-0005Md-TZ for qemu-devel@nongnu.org; Wed, 05 Mar 2014 10:34:41 -0500 Date: Wed, 5 Mar 2014 16:34:41 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140305153440.GB1709@irqsave.net> References: <1394031649-31915-1-git-send-email-kwolf@redhat.com> <1394031649-31915-3-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1394031649-31915-3-git-send-email-kwolf@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] block: Fix bs->request_alignment assertion for bs->sg=1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, pl@kamp.de, qemu-devel@nongnu.org The Wednesday 05 Mar 2014 =E0 16:00:49 (+0100), Kevin Wolf wrote : > For sg backends, bs->request_alignment is meaningless and may be 0. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/block.c b/block.c > index 38bbdf3..f01b91c 100644 > --- a/block.c > +++ b/block.c > @@ -935,7 +935,7 @@ static int bdrv_open_common(BlockDriverState *bs, B= lockDriverState *file, > =20 > bdrv_refresh_limits(bs); > assert(bdrv_opt_mem_align(bs) !=3D 0); > - assert(bs->request_alignment !=3D 0); > + assert((bs->request_alignment !=3D 0) || bs->sg); > =20 > #ifndef _WIN32 > if (bs->is_temporary) { > --=20 > 1.8.1.4 >=20 >=20 Reviewed-by: Benoit Canet