From: Daniel Vetter Subject: Re: [PATCH] drm/i915: print connector mode list in display_info Date: Wed, 5 Mar 2014 18:11:05 +0100 Message-ID: <20140305171105.GK17001@phenom.ffwll.local> References: <1392928797-3944-1-git-send-email-jbarnes@virtuousgeek.org> <20140220205059.GD17020@nuc-i3427.alporthouse.com> <20140305125500.GE17001@phenom.ffwll.local> <20140305074913.17e6b4fa@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com [209.85.215.174]) by gabe.freedesktop.org (Postfix) with ESMTP id B704FFA7AC for ; Wed, 5 Mar 2014 09:11:13 -0800 (PST) Received: by mail-ea0-f174.google.com with SMTP id f15so1157351eak.5 for ; Wed, 05 Mar 2014 09:11:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140305074913.17e6b4fa@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 05, 2014 at 07:49:13AM -0800, Jesse Barnes wrote: > On Wed, 5 Mar 2014 13:55:00 +0100 > Daniel Vetter wrote: > > > On Thu, Feb 20, 2014 at 08:50:59PM +0000, Chris Wilson wrote: > > > On Thu, Feb 20, 2014 at 12:39:57PM -0800, Jesse Barnes wrote: > > > > Useful for bug reports. > > > > > > Hey, this would be useful for error state as well :) > > > > I seem to have pissed of Jesse yesterday, so not going to insist here ;-) > > > > Queued for -next, thanks for the patch. > > Move along, nothing to see here. :) > > But yeah, adding this to error state might be useful just so things get > bundled up I guess? > > It's a bunch more refactoring to get the printouts into a buffer for > use in either case though. Not sure it's worth it since we can just > ask for both files. On 2nd though we should have the stuff which can change and yeah just asking for all the debugfs files should be ok. So sounds like the current code is Good Enough. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch