From: Daniel Vetter Subject: Re: [PATCH] drm/i915/bdw: MU_FLUSH_DW a qword instead of dword Date: Wed, 5 Mar 2014 19:33:11 +0100 Message-ID: <20140305183311.GX17001@phenom.ffwll.local> References: <1393954736-1397-1-git-send-email-benjamin.widawsky@intel.com> <20140305092434.GA20735@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 11237FA53B for ; Wed, 5 Mar 2014 10:33:17 -0800 (PST) Received: by mail-ee0-f50.google.com with SMTP id c13so645710eek.23 for ; Wed, 05 Mar 2014 10:33:15 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140305092434.GA20735@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 05, 2014 at 09:24:34AM +0000, Chris Wilson wrote: > On Tue, Mar 04, 2014 at 09:38:56AM -0800, Ben Widawsky wrote: > > The actual post sync op is "Write Immediate Data QWord." It is therefore > > arguable that we should have always done a qword write. > > Not really since the spec explicitly says that we can choose either a > dword or qword write. Note that qword writes also currently require a > 64 byte alignment. Yeah, that's also my reading of the spec - the lenght field selects whether the hw does a qword or dword write, and the qword needs to be specially aligned. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch