From: Daniel Vetter Subject: Re: [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression Date: Wed, 5 Mar 2014 21:28:20 +0100 Message-ID: <20140305202820.GB17001@phenom.ffwll.local> References: <1393996999-1930-1-git-send-email-benjamin.widawsky@intel.com> <87bnxl3t5j.fsf@intel.com> <20140305152437.GA20062@bwidawsk.net> <20140305201951.GA2777@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by gabe.freedesktop.org (Postfix) with ESMTP id A94CEFA88E for ; Wed, 5 Mar 2014 12:28:25 -0800 (PST) Received: by mail-ea0-f176.google.com with SMTP id o10so1282819eaj.7 for ; Wed, 05 Mar 2014 12:28:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140305201951.GA2777@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 05, 2014 at 12:19:51PM -0800, Ben Widawsky wrote: > On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote: > > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote: > > > On Wed, 05 Mar 2014, Ben Widawsky wrote: > > > > The PDE needs to wrap after writing all the PTEs. Quite a small/silly > > > > bug to find in the massive change. It was introduced: > > > > commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d > > > > Author: Ben Widawsky > > > > Date: Thu Feb 20 11:51:21 2014 -0800 > > > > > > > > drm/i915/bdw: Reorganize PT allocations > > > > > > As noted in the bug, the commit merged to dinq is correct, and the > > > commit referenced above apparently only lives in some temporary branch. > > > > > > BR, > > > Jani. > > > > > > > My eyes are playing tricks on me. Sorry for the noise. > > > > It's not my eyes. It's something else. WTF is going on? My apologies, I seem to have been blind. Patch merged, will squash in. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch