From: Zhenyu Wang Subject: Re: [PATCH] drm/i915: Fix drain latency precision multipler for VLV Date: Thu, 6 Mar 2014 10:05:08 +0800 Message-ID: <20140306020508.GO2692@zhen-hp.sh.intel.com> References: <1393541406-13472-1-git-send-email-zhenyuw@linux.intel.com> <20140305165148.GT3852@intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1320945726==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 9300BFAAD8 for ; Wed, 5 Mar 2014 18:05:16 -0800 (PST) In-Reply-To: <20140305165148.GT3852@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1320945726== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vDEbda84Uy/oId5W" Content-Disposition: inline --vDEbda84Uy/oId5W Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014.03.05 18:51:48 +0200, Ville Syrj=E4l=E4 wrote: > > entries =3D (clock / 1000) * pixel_size; > > *plane_prec_mult =3D (entries > 256) ? >=20 > The threshold should also be reduced to 128 entries. >=20 hmm, I'll double check if this is really required or not. > > - DRAIN_LATENCY_PRECISION_32 : DRAIN_LATENCY_PRECISION_16; > > + DRAIN_LATENCY_PRECISION_64 : DRAIN_LATENCY_PRECISION_32; > > *plane_dl =3D (64 * (*plane_prec_mult) * 4) / ((clock / 1000) * > > pixel_size); > ^^^^^^^^^^^^^^^^^ > Maybe replace the divisor here w/ just 'entrie' since it's same thing. > Makes it a bit easier to see the relationship between this and the way > the precision is selected. >=20 yeah, but that might be another seperate patch besides the precision multipler this one trys to fix. Thanks for review this. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --vDEbda84Uy/oId5W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlMX19QACgkQsQQaM014GCdnGACeKfsa8+8G1U96V2I4+cbs3hmi Uh8AnRw5w8gNV2exblxcCQqCnRzYTfti =tMms -----END PGP SIGNATURE----- --vDEbda84Uy/oId5W-- --===============1320945726== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1320945726==--