From: Jesse Barnes Subject: Re: [PATCH v2 18/21] drm/i915: vlv: factor out valleyview_display_irq_install Date: Thu, 6 Mar 2014 11:17:03 -0800 Message-ID: <20140306111703.5435770a@jbarnes-desktop> References: <1393953790-20733-1-git-send-email-imre.deak@intel.com> <1393953790-20733-19-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy13-pub.mail.unifiedlayer.com (oproxy13-pub.mail.unifiedlayer.com [69.89.16.30]) by gabe.freedesktop.org (Postfix) with SMTP id 0F89CFA096 for ; Thu, 6 Mar 2014 11:16:33 -0800 (PST) In-Reply-To: <1393953790-20733-19-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 4 Mar 2014 19:23:07 +0200 Imre Deak wrote: > +void valleyview_enable_display_irqs(struct drm_i915_private *dev_priv) > +{ > + assert_spin_locked(&dev_priv->irq_lock); > + > + if (dev_priv->display_irqs_enabled) > + return; > + > + dev_priv->display_irqs_enabled = true; > + > + if (dev_priv->dev->irq_enabled) > + valleyview_display_irqs_install(dev_priv); > +} This made me do a double take, then I saw you were checking the actual drm_device irq enabled state rather than checking the new field again... Looks good. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center