From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Avoid div by zero when pixel clock is large Date: Thu, 6 Mar 2014 21:57:00 +0100 Message-ID: <20140306205700.GJ17001@phenom.ffwll.local> References: <1392380337-11462-1-git-send-email-ville.syrjala@linux.intel.com> <20140214122829.GF32602@nuc-i3427.alporthouse.com> <20140214124039.GI3852@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com [209.85.215.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 2446BFAB0F for ; Thu, 6 Mar 2014 12:57:05 -0800 (PST) Received: by mail-ea0-f169.google.com with SMTP id h14so1957243eaj.14 for ; Thu, 06 Mar 2014 12:57:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140214124039.GI3852@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 14, 2014 at 02:40:39PM +0200, Ville Syrj=E4l=E4 wrote: > On Fri, Feb 14, 2014 at 12:28:29PM +0000, Chris Wilson wrote: > > On Fri, Feb 14, 2014 at 02:18:57PM +0200, ville.syrjala@linux.intel.com= wrote: > > > From: Ville Syrj=E4l=E4 > > > = > > > Make sure the line_time_us isn't zero in the gmch watermarks code as > > > that would cause a div by zero. This can be triggered by specifying > > > a very fast pixel clock for the mode. > > = > > Very fast but valid? > = > 74.25 GHz. I'm not sure which way you would classify that :) I've added this to the commit message ... > > If it was just very fast, we should have rejected > > the mode line. > = > Except we do more or less zero checks on the mode supplied to the > setcrtc ioctl. Something we should really get fixed at some point. Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch