From: Tejun Heo Subject: Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write Date: Fri, 14 Mar 2014 10:54:30 -0400 Message-ID: <20140314145430.GL12613@htj.dyndns.org> References: <20140313200119.GB504@quack.suse.cz> <20140313143456.157404fd7f208638ca70e317@linux-foundation.org> <20140314130712.GC12613@htj.dyndns.org> <20140314141143.GH12613@htj.dyndns.org> <20140314141511.GF18583@quack.suse.cz> <20140314145215.GG18583@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roman Peniaev , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20140314145215.GG18583@quack.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Mar 14, 2014 at 03:52:15PM +0100, Jan Kara wrote: > Well, for ext2, you can use ext4 kernel driver which takes care of > REQ_FLUSH properly. For fat, you'll need to fix the fs... This is a bit surprising tho. Were we always like this? We never had even stupid "flush down everything and sync"? Or is this something we broke while morphing flush implementation several times in the past years? Thanks. -- tejun