From: Christoph Hellwig Subject: Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write Date: Sat, 15 Mar 2014 02:09:32 -0700 Message-ID: <20140315090932.GA24576@infradead.org> References: <20140313200119.GB504@quack.suse.cz> <20140313143456.157404fd7f208638ca70e317@linux-foundation.org> <20140314130712.GC12613@htj.dyndns.org> <20140314141143.GH12613@htj.dyndns.org> <20140314141511.GF18583@quack.suse.cz> <20140314145215.GG18583@quack.suse.cz> <20140314145430.GL12613@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Roman Peniaev , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe To: Tejun Heo Return-path: Content-Disposition: inline In-Reply-To: <20140314145430.GL12613@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Mar 14, 2014 at 10:54:30AM -0400, Tejun Heo wrote: > This is a bit surprising tho. Were we always like this? We never had > even stupid "flush down everything and sync"? Or is this something we > broke while morphing flush implementation several times in the past > years? It's something that never worked in Linux. Until XFS went ahead and enabled barriers by default no filesystem in Linux ever flushed the volatile cache by default, and most couldn't (and still can't) even if you asked them to.