From: Wolfgang Denk Date: Wed, 19 Mar 2014 20:20:18 +0100 Subject: [U-Boot] [PATCH v4 2/6] lib: uuid: code refactor for proper maintain between uuid bin and string In-Reply-To: <1395251911-26540-2-git-send-email-p.marczak@samsung.com> References: <5ef7cdb8df4fb05c3c371e29d7a61e28e1563a68.1394807506.git.p.marczak@samsung.com> <1395251911-26540-1-git-send-email-p.marczak@samsung.com> <1395251911-26540-2-git-send-email-p.marczak@samsung.com> Message-ID: <20140319192018.780FC382244@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Przemyslaw Marczak, In message <1395251911-26540-2-git-send-email-p.marczak@samsung.com> you wrote: > Changes in lib/uuid.c to: > - uuid_str_to_bin() > - uuid_bin_to_str() Checkpatch says: WARNING: do not add new typedefs #199: FILE: include/uuid.h:10: +typedef enum { WARNING: line over 80 characters #209: FILE: include/uuid.h:20: +void uuid_bin_to_str(unsigned char *uuid_bin, char *uuid_str, uuid_str_t format); Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de An expert is a person who avoids the small errors while sweeping on to the grand fallacy.