From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: Print how many objects are shared in per-process statsg Date: Thu, 20 Mar 2014 07:40:37 +0000 Message-ID: <20140320074037.GL4890@nuc-i3427.alporthouse.com> References: <20140319065520.GC20605@nuc-i3427.alporthouse.com> <1395236746-15093-1-git-send-email-chris@chris-wilson.co.uk> <1395236746-15093-2-git-send-email-chris@chris-wilson.co.uk> <20140320044248.GB1748@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F7738920D for ; Thu, 20 Mar 2014 00:40:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140320044248.GB1748@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 19, 2014 at 09:42:49PM -0700, Ben Widawsky wrote: > On Wed, Mar 19, 2014 at 01:45:46PM +0000, Chris Wilson wrote: > > Signed-off-by: Chris Wilson > > Any clue how you intend to use this for a commit message (I'm actually > curious)? Also, the subject is wrong, you're counting size, not > quantity. Anyhoo, looks correct. Knowing how much of the allocated objects are shared between processes helps gauge whether a process is leaking private objects, or if it simply a display server suffering memory pressure from lots of clients. > Reviewed-by: Ben Widawsky -- Chris Wilson, Intel Open Source Technology Centre