Received: from eggs.gnu.org ([2001:4830:134:3::10]:57758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQdBS-0000aC-9L for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQdBN-0004tH-Mm for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:38:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQdBN-0004tD-FF for qemu-devel@nongnu.org; Thu, 20 Mar 2014 09:38:53 -0400 Date: Thu, 20 Mar 2014 14:38:32 +0100 From: Kevin Wolf Message-ID: <20140320133832.GB3450@noname.redhat.com> References: <6eff2de18cc1e860f31a1ea9c1afc71b8ee12f48.1395035846.git.hutao@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6eff2de18cc1e860f31a1ea9c1afc71b8ee12f48.1395035846.git.hutao@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Stefan Hajnoczi , qemu-devel@nongnu.org Am 17.03.2014 um 07:53 hat Hu Tao geschrieben: > This adds a preallocation=full mode to qcow2 image creation, which > creates a non-sparse image file. > > Signed-off-by: Hu Tao I see that you changed the implementation from bdrv_preallocate() to bdrv_create() options in v4 after Stefan had asked whether bdrv_preallocate() was really necessary or just complicating things. In hindsight, do you really think the new code is simpler? I certainly think this one is rather adventurous and the formulas to precalculate the image file size are easy to get wrong. Kevin