From: "Luis R. Rodriguez" Subject: Re: [PATCH v2 7/7] systemd: add support initial xen systemd service files Date: Sat, 22 Mar 2014 03:26:21 +0100 Message-ID: <20140322022621.GI5011@wotan.suse.de> References: <1395262733-11885-1-git-send-email-mcgrof@do-not-panic.com> <1395262733-11885-8-git-send-email-mcgrof@do-not-panic.com> <1395396494.27358.18.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2177482706784847675==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WRBdf-0007B1-Ok for xen-devel@lists.xenproject.org; Sat, 22 Mar 2014 02:26:23 +0000 In-Reply-To: <1395396494.27358.18.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , Jan =?utf-8?Q?R=C4=99korajski?= , Ian Jackson , Jacek Konieczny , M A Young , xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org --===============2177482706784847675== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ytoMbUMiTKPMT3hY" Content-Disposition: inline --ytoMbUMiTKPMT3hY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 21, 2014 at 10:08:14AM +0000, Ian Campbell wrote: > On Wed, 2014-03-19 at 13:58 -0700, Luis R. Rodriguez wrote: > > [...] > > diff --git a/tools/hotplug/Linux/systemd/oxenstored.service.in b/tools/= hotplug/Linux/systemd/oxenstored.service.in > > [...] > > +ExecStartPost=3D-@BINDIR@/xenstore-write "/local/domain/0/name" "Domai= n-0" > > diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/h= otplug/Linux/systemd/xenstored.service.in > [...] > > +ExecStartPost=3D@BINDIR@/xenstore-write "/local/domain/0/name" "Domain= -0" >=20 > I accidentally deleted the subthread about writing domid here too, but I > was wondering if it might be better to have a common xenstore service > which depends on oxenstore.service || cxenstore.service and then does > this kind of common implementation agnostic setup in one place where it > can't get out of sync easily? That's what I was hoping for to achieve with the socket file but that seems to not work as expected, even if you claim the socket explicitly as part of both oxenstored and xenstored. To me this could likely be an enhancement to systemd but not sure. systemd does not allow one to use || as part of the language for requiremen= ts, it also does not let you use || to exec stuff for services which are of type "Forking". This means we either do some sort of meta @VARIABLE@ substitution or a comm= on init routine which will do the or checking for us. The only problem with th= is is systemd will treat the Forking type service ExecStart as the process to = care for, and if we add a wrapper that'd be dead. I haven't tried to implement o= ne but I think this could confuse systemd or administrators. > (not sure if that is the "systemd way" but thought I'd throw it out > there) Its what I wanted to do as well. I tried. Luis --ytoMbUMiTKPMT3hY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAEBAgAGBQJTLPTNAAoJEPep4JnvMe6ziDgP/0O4StUDZK3gSolM7TzWxfkZ 0IhM7wuydfR3OUXvYEL0i2mXbA4GsnMmJhlRSnSILd8An3IE5p3I/sYL4myXlf1C M6hhksOj9BJQUzwqJ3UgYx0m82groITZNElvAKpPmk1hjlQmsCHLCVjdLdqxQeUa G13J13VVLzAnRe5wSjbwWbshOp3PzTlXyQOLa4O5QYHRErV7f0TJbg7TnSNtuYq6 Uvo0exjfOdChNvBRvWc/TIq/+O+wEvchi6F78mB/0gUc5B7YuPc+pn180JGHge5v CvM4kddm9oh9u+9j7izRdCSIGdjv6bPmp+6AjmPmt7JQWG2pXIFENDa6Ghi5M/Po 8tqox8mN9bC/fofaBXUIb6QWMZdp5lzXpEYf5W/idB2USIXAt4kLLudvF7Pxo8g1 uI7oXFolxOHMjs2xERlFjuWjseVmDuOAOHJ5T8oYi0phGCODTFQJrmvD6ukWWNjZ UTNem/UWOYgaMfMsNJwSISVYUHL06Fn4cbPSILZbQ33xvUl/6o3AmkbQ8qUcPnRP otHFFxudQQB0DItladM8yS9Ll8JgFG5tQGuJaJgZDgPVzknWtqKHXbZTDrfif7L6 TEiqgS2TyrT6H4TDlSNntERpP37zXx8t4zHOt87N5aAR9cjuVk4ntjdHl3VeuV5I 1609H89eoaj24lL0SoAu =lyWe -----END PGP SIGNATURE----- --ytoMbUMiTKPMT3hY-- --===============2177482706784847675== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2177482706784847675==--