Return-Path: From: "Stefan Lippers-Hollmann" To: "Greg Kroah-Hartman" Subject: Re: [PATCH 3.13 072/149] ACPI / resources: ignore invalid ACPI device resources Date: Sat, 22 Mar 2014 02:30:43 +0000 Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zhang Rui , "Rafael J. Wysocki" References: <20140321000436.377902063@linuxfoundation.org> <20140321000439.452672105@linuxfoundation.org> In-Reply-To: <20140321000439.452672105@linuxfoundation.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201403220230.49584.s.L-H@gmx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi On Friday 21 March 2014, Greg Kroah-Hartman wrote: > 3.13-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Zhang Rui > > commit b355cee88e3b1a193f0e9a81db810f6f83ad728b upstream. > > ACPI table may export resource entry with 0 length. > But the current code interprets this kind of resource in a wrong way. > It will create a resource structure with > res->end = acpi_resource->start + acpi_resource->len - 1; > > This patch fixes a problem on my machine that a platform device fails > to be created because one of its ACPI IO resource entry (start = 0, > end = 0, length = 0) is translated into a generic resource with > start = 0, end = 0xffffffff. > > Signed-off-by: Zhang Rui > Signed-off-by: Rafael J. Wysocki > Signed-off-by: Greg Kroah-Hartman [...] This patch should probably be dropped from -stable (3.13 and 3.10) for the time being, it causes this warning: pnp 00:01: unknown resource type 4 in _CRS pnp 00:01: can't evaluate _CRS: 1 on all systems I've tested it on so far (~12 systems of vastly varying components and age, covering amd64 and i386). This also seems to affect others as well: http://www.spinics.net/lists/linux-acpi/msg49431.html http://www.spinics.net/lists/linux-acpi/msg49438.html Regards Stefan Lippers-Hollmann