From: Daniel Vetter Subject: Re: [PATCH 0/6] Rendering Specific HW Workarounds for VLV Date: Mon, 24 Mar 2014 10:35:09 +0100 Message-ID: <20140324093509.GD26878@phenom.ffwll.local> References: <1395643764-24353-1-git-send-email-sourab.gupta@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53]) by gabe.freedesktop.org (Postfix) with ESMTP id C5BC56E921 for ; Mon, 24 Mar 2014 02:35:13 -0700 (PDT) Received: by mail-ee0-f53.google.com with SMTP id b57so4166942eek.26 for ; Mon, 24 Mar 2014 02:35:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395643764-24353-1-git-send-email-sourab.gupta@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sourab.gupta@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 24, 2014 at 12:19:18PM +0530, sourab.gupta@intel.com wrote: > From: Sourab Gupta > > This patch series adds rendering specific HW workarounds for VLV platform. > These patches leads to stable behavior on VLV, especially > when playing 3D Apps, benchmarks. > > Though, the patch set was submitter earlier, this new patch set is initiating > a clean thread. We have addressed the comments on earlier patches and given > the latest version of these patches in a single thread. > > Akash Goel (6): > drm/i915/vlv: Added a rendering specific Hw WA > 'WaTlbInvalidateStoreDataBefore' > drm/i915/vlv: Added a rendering specific Hw WA > 'WaSendDummy3dPrimitveAfterSetContext' > drm/i915: Enabling the TLB invalidate bit in GFX Mode register > drm/i915/vlv: Remove the enabling of VS_TIMER_DISPATCH bit in MI MODE > reg > drm/i915/vlv:Implement WaDisable_RenderCache_OperationalFlush > drm/i915/vlv: Modified Implementation of WaDisableL3Bank2xClockGate Thanks for resending. But your patches are missing the in-patch changelogs completely, which makes reviewing them hard - I have no idea what was discussed already and why we've reached certain conclusions. Can you please dig out the changelogs from older resends (I remember v2/v3/v4 of some of your patches) and add this again? Also you missed e.g. Chris' tested-by on the tlb invalidation optimization. And the commit message fails to state that you've only tested this on vlv, but Chris has done the required testing on ivb/hsw. Such details are important in case the patch breaks something in the future. One comment on one patch before I've noticed this, otherwise I think it's better to wait for the resend. Thanks. > > drivers/gpu/drm/i915/i915_gem_context.c | 65 ++++++++++++++++++++++++++++++++- > drivers/gpu/drm/i915/i915_reg.h | 6 +++ > drivers/gpu/drm/i915/intel_pm.c | 13 ++++++- > drivers/gpu/drm/i915/intel_ringbuffer.c | 38 ++++++++++++++++++- > drivers/gpu/drm/i915/intel_ringbuffer.h | 1 + > 5 files changed, 117 insertions(+), 6 deletions(-) > > -- > 1.8.5.1 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch