From: Damien Lespiau Subject: Re: [PATCH 1/3] drm/i915: Don't set mode_config's cursor size Date: Tue, 25 Mar 2014 14:59:18 +0000 Message-ID: <20140325145918.GD8248@strange.amr.corp.intel.com> References: <1395758972-31316-1-git-send-email-damien.lespiau@intel.com> <1395758972-31316-2-git-send-email-damien.lespiau@intel.com> <20140325145456.GC1719@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id F2C9D6E32F for ; Tue, 25 Mar 2014 07:59:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140325145456.GC1719@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Sagar Kamble List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 25, 2014 at 02:54:56PM +0000, Chris Wilson wrote: > On Tue, Mar 25, 2014 at 02:49:30PM +0000, Damien Lespiau wrote: > > Those fields are supposed to be a good default value for the cursor > > size, intended for the case where the hardware doesn't support 64x64 > > cursors, for use with a hw agnostic DDX driver for instance. > > > > We're fine with 64x64 cursors though and don't need to set those fields > > (DRM core will return 64 is we don't). If we declare 256x256, that > > generic driver will use a big buffer for the cursor, without any good > > reason. > > How does userspace now know that 256x256 cursors are support for HiDPI? It doesn't currently? a property on the cursor plane with the list of supported formats in the brave new full drm_plane world seems like a good option to me. -- Damien