From: Masahiro Yamada <yamada.m@jp.panasonic.com>
Date: Fri, 28 Mar 2014 14:42:50 +0900
Subject: [U-Boot] [PATCH 2/2] patman: Avoid duplicate sign-offs
In-Reply-To: <1395530037-19588-2-git-send-email-sjg@chromium.org>
References: <1395530037-19588-1-git-send-email-sjg@chromium.org>
	<1395530037-19588-2-git-send-email-sjg@chromium.org>
Message-ID: <20140328144250.DB45.AA925319@jp.panasonic.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,


> Collect all Signed-off-by tags in a commit and make sure that there are
> no duplicates.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>


I have a change request about this patch.

It is true this patch avoids duplication, but
it changes the order *-by: credits.



For example, assume something like this in my git-log

blah blah blah

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Reported-by: For Bar <foo@bar.com>



Patman changes it to

blah blah blah

Reported-by: For Bar <foo@bar.com>
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>



I want Patman to touch *-by: credits only when it is really necessary.
 [1] when adding a missing Signed-off-by: 
 [2] when deleting redundant Signed-off-by:



Best Regards
Masahiro Yamada