From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Kill crtc->plane checks from the primary plane update hooks Date: Mon, 31 Mar 2014 22:37:42 +0200 Message-ID: <20140331203742.GB22327@phenom.ffwll.local> References: <20140331173354.GX22327@phenom.ffwll.local> <1396290581-7423-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CED26E424 for ; Mon, 31 Mar 2014 13:37:47 -0700 (PDT) Received: by mail-wi0-f182.google.com with SMTP id d1so4032184wiv.9 for ; Mon, 31 Mar 2014 13:37:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396290581-7423-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 31, 2014 at 09:29:41PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > These were apparently meant to protect the SAREA which only has > room for two pipes, but things clearly went a bit wonky when > first the .update_plane() hooks were split up and then pipe C > got introduced. > = > The checks actually protecting the SAREA live in > intel_crtc_update_sarea() these days, so the checks in the primary > plane update hooks are just historical leftovers which are to be > eliminated. > = > Signed-off-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch