From: Damien Lespiau Subject: Re: [PATCH 41/49] drm/i915/bdw: LR context switch interrupts Date: Wed, 2 Apr 2014 12:42:11 +0100 Message-ID: <20140402114211.GA30534@strange.amr.corp.intel.com> References: <1395943218-7708-1-git-send-email-oscar.mateo@intel.com> <1395943218-7708-42-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E97D36EA8B for ; Wed, 2 Apr 2014 04:42:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395943218-7708-42-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: oscar.mateo@intel.com Cc: Thomas Daniel , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Mar 27, 2014 at 06:00:10PM +0000, oscar.mateo@intel.com wrote: > @@ -543,6 +545,9 @@ static int init_ring_common_lrc(struct intel_engine *ring) > ringbuf->space = ringbuf->size; > ringbuf->last_retired_head = -1; > > + I915_WRITE_IMR(ring, ~(ring->irq_enable_mask | ring->irq_keep_mask)); > + I915_WRITE(RING_HWSTAM(ring->mmio_base), ~(ring->irq_enable_mask | ring->irq_keep_mask)); > + > return 0; > } > Two little things: - I don't see any place where we look at the interrupt reporting in the HWS page, so we could just initialize HWSTAM to 0xffffffff - There's a programming note we don't seem to respect "At most 1 bit can be unmasked at any given time". That would be solved by the first point if I did not miss a call site using it. -- Damien