From: Damien Lespiau Subject: Re: [PATCH 42/49] drm/i915/bdw: Get prepared for a two-stage execlist submit process Date: Fri, 4 Apr 2014 14:24:30 +0100 Message-ID: <20140404132430.GA4844@strange.amr.corp.intel.com> References: <1395943218-7708-1-git-send-email-oscar.mateo@intel.com> <1395943218-7708-43-git-send-email-oscar.mateo@intel.com> <20140404111235.GB28222@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D73536E0C8 for ; Fri, 4 Apr 2014 06:24:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140404111235.GB28222@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: oscar.mateo@intel.com Cc: Thomas Daniel , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 04, 2014 at 12:12:35PM +0100, Damien Lespiau wrote: > On Thu, Mar 27, 2014 at 06:00:11PM +0000, oscar.mateo@intel.com wrote: > > +int gen8_switch_context_queue(struct intel_engine *ring, > > + struct i915_hw_context *to, > > + u32 tail) > > +{ > > + struct drm_i915_gem_request *req = NULL; > > + unsigned long flags; > > + bool was_empty; > > + > > + req = (struct drm_i915_gem_request *) > > + kmalloc(sizeof(struct drm_i915_gem_request), GFP_KERNEL); > > + req->ring = ring; > > + req->ctx = to; > > + i915_gem_context_reference(req->ctx); > > + req->tail = tail; > > Need to test if the allocation has succeeded and return an error if not. Also, no need for the cast, kmalloc returns a void *. We usually use sizeof(*req) to be safe against variables changing type without updating the allocation size (someont the compiler wouldn't warn about). -- Damien