From: Al Viro Subject: [RFC] odd thing in btrfs_file_aio_write() Date: Mon, 14 Apr 2014 01:26:25 +0100 Message-ID: <20140414002625.GQ18016@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Chris Mason Return-path: Content-Disposition: inline Sender: linux-btrfs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org end_pos = round_up(pos + iov->iov_len, root->sectorsize); added in commit 3ac0d7b96a268a98bd474cab8bce3a9f125aaccf Author: Qu Wenruo Date: Thu Mar 27 02:51:58 2014 +0000 btrfs: Change the expanding write sequence to fix snapshot related bug. doesn't look right - after all, just split the first iovec in the array and end_pos will go down. Do we want pos + count instead of pos + iov->iov_len there?