From: Julien Cristau Subject: Re: [PATCH] load_cursor_argb is supposed to return a Bool, not void Date: Mon, 14 Apr 2014 20:35:54 +0200 Message-ID: <20140414183554.GM4433@betterave.cristau.org> References: <1397499723-19704-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1397499723-19704-1-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xorg-devel-bounces-go0+a7rfsptAfugRpC6u6w@public.gmane.org Sender: "xorg-devel" To: Keith Packard Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Apr 14, 2014 at 11:22:03 -0700, Keith Packard wrote: > By mis-declaring this function, we ended up using software cursors > because the value seen by the caller was 0. > > Signed-off-by: Keith Packard > --- > src/sna/sna_display.c | 8 ++++++-- > src/sna/sna_display_fake.c | 3 ++- > src/uxa/intel_display.c | 7 +++++-- > 3 files changed, 13 insertions(+), 5 deletions(-) > Only since http://cgit.freedesktop.org/xorg/xserver/commit/?id=901fbfbbbd71c0d82080957f8ba09eebbc786f2b Which could probably have used a different name to avoid silent breakage. Cheers, Julien _______________________________________________ xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel