From: Andrew Morton Date: Tue, 22 Apr 2014 18:28:28 +0000 Subject: Re: [PATCH 0/4 V3] Print traces on softlockup Message-Id: <20140422112828.ea511cefa17affb99d9aa97f@linux-foundation.org> List-Id: References: <1398179848-197479-1-git-send-email-dzickus@redhat.com> In-Reply-To: <1398179848-197479-1-git-send-email-dzickus@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Don Zickus Cc: LKML , x86@kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, mguzik@redhat.com On Tue, 22 Apr 2014 11:17:24 -0400 Don Zickus wrote: > Added more patches to handle the 'uniprocessor' panic case by sending NMIs > to every cpu but self. Only affects x86, sparc. > Looks OK to me. A couple of things: - Patches 1-3 should be combined so we don't create bisection holes due to x86 and sparc build errors. - Patch 4 adds stuff which is unusable on uniprocessor, especially the presence of /proc/sys/kernel/softlockup_all_cpu_backtrace. We already have #ifdef CONFIG_SMP in kern_table, so do more of that?