From: Daniel Vetter Subject: Re: [PATCH i-g-t v2 0/8] kms_cursor_crc enhancements Date: Fri, 25 Apr 2014 16:07:48 +0200 Message-ID: <20140425140748.GT26374@phenom.ffwll.local> References: <1397131692-2857-1-git-send-email-antti.koskipaa@linux.intel.com> <20140425132702.GT18465@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 939AC6EE9B for ; Fri, 25 Apr 2014 07:07:53 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id b15so2851311eek.20 for ; Fri, 25 Apr 2014 07:07:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140425132702.GT18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 25, 2014 at 04:27:02PM +0300, Ville Syrj=E4l=E4 wrote: > On Thu, Apr 10, 2014 at 03:08:04PM +0300, Antti Koskipaa wrote: > > This patch series enhances the cursor test to actually be useful. > > = > > The old "black transparent cursor on black background" tests are > > replaced with a visible cursor and the framework is changed to > > be more flexible and extendable. This way cursor rotation tests > > can be added with ease in the future. > > = > > Also adds a couple more tests to the current set. > > = > > v2: > > - reinstate "go nuts" -test > > - Add background picture for better test coverage > > = > > Antti Koskipaa (8): > > kms_cursor_crc: Remove some test cases and change cursor to color > > kms_cursor_crc: Move cursor enable and disable calls where they belong > > kms_cursor_crc: Use a function pointer to call test > > kms_cursor_crc: Separate onscreen and offscreen tests > > kms_cursor_crc: Add reference software rendering > > kms_cursor_crc: Add moving cursor test > > kms_cursor_crc: Add random cursor placement test > > kms_cursor_crc: Add background picture > = > I pushed the lot, and fixed the small issue in 2/8 that I pointed out. > = > I also pushed a pile of extra fixes, mainly to fix --list-subtests, > and I also tried to fix my gen2 LVDS vs. pipe B issue, which I > suppose is the same thing as this bug: > https://bugs.freedesktop.org/show_bug.cgi?id=3D75131 This is a general issue with the current igt kms helper, and it's going to bite us again with the chv 3 pipe support due to pipe restrictions on the DP ports. I have a todo (and some patches) somewhere, but just didn't get around to this yet :( There's a few other issues with the high-level helpers like no sane support to reset all the state - after the first test most subsequent ones end up all skipping ... -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch