From: "Luis R. Rodriguez" Subject: Re: [PATCH v2 6/7] tools/xendomains: move to sbin and use init helper Date: Mon, 28 Apr 2014 07:11:19 +0200 Message-ID: <20140428051119.GA11838@wotan.suse.de> References: <1395262733-11885-1-git-send-email-mcgrof@do-not-panic.com> <1395262733-11885-7-git-send-email-mcgrof@do-not-panic.com> <1395416050.19839.153.camel@kazak.uk.xensource.com> <20140322021741.GH5011@wotan.suse.de> <1395655795.19365.16.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wedqc-0006DM-JJ for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 05:11:22 +0000 Content-Disposition: inline In-Reply-To: <1395655795.19365.16.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , Jan =?utf-8?Q?R=C4=99korajski?= , Ian Jackson , Jacek Konieczny , M A Young , xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org On Mon, Mar 24, 2014 at 10:09:55AM +0000, Ian Campbell wrote: > On Sat, 2014-03-22 at 03:17 +0100, Luis R. Rodriguez wrote: > > What I mean by keeping the history is you can do git log --follow on the > > script after the move. > > The history is never lost. If git was actually losing history there > would be uproar, and the structure of the repo prevents it anyway. > > I skanked up an example commit (see below) and git comes up with: > 2 files changed, 54 insertions(+), 610 deletions(-) > rewrite tools/hotplug/Linux/init.d/xendomains (91%) > rename tools/hotplug/Linux/{init.d => }/xendomains (93%) > and "git log --follow tools/hotplug/Linux/xendomains" works exactly as I > expected, so I think things are fine. Did you try git format-patch -M on that? I now see what you see but I don't see git format-patch respecting the rename detection, either way we'll know it will be so I'll just submit it, just to be clear on the submission that I just move the code, its not a magical rewrite. Luis