From: "Volkin, Bradley D" Subject: Re: [PATCH 12/14] drm/i915/bdw: enable eDRAM. Date: Mon, 28 Apr 2014 09:27:50 -0700 Message-ID: <20140428162750.GD25551@bdvolkin-ubuntu-desktop> References: <1397855070-4480-1-git-send-email-rodrigo.vivi@gmail.com> <1397855070-4480-13-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 885CB6E89F for ; Mon, 28 Apr 2014 09:27:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1397855070-4480-13-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: "intel-gfx@lists.freedesktop.org" , Ben Widawsky , "Widawsky, Benjamin" List-Id: intel-gfx@lists.freedesktop.org Reviewed-by: Brad Volkin On Fri, Apr 18, 2014 at 02:04:28PM -0700, Rodrigo Vivi wrote: > From: Ben Widawsky > > The same register exists for querying and programming eDRAM AKA eLLC. So > we can simply use it. For now, use all the same defaults as we had > for Haswell, since like Haswell, I have no further details. > > I do not actually have a part with eDRAM, so I cannot test this. > > Signed-off-by: Ben Widawsky > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_uncore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c > index c8969e3..0e6b502 100644 > --- a/drivers/gpu/drm/i915/intel_uncore.c > +++ b/drivers/gpu/drm/i915/intel_uncore.c > @@ -373,7 +373,7 @@ void intel_uncore_early_sanitize(struct drm_device *dev) > if (HAS_FPGA_DBG_UNCLAIMED(dev)) > __raw_i915_write32(dev_priv, FPGA_DBG, FPGA_DBG_RM_NOCLAIM); > > - if (IS_HASWELL(dev) && > + if ((IS_HASWELL(dev) || IS_BROADWELL(dev)) && > (__raw_i915_read32(dev_priv, HSW_EDRAM_PRESENT) == 1)) { > /* The docs do not explain exactly how the calculation can be > * made. It is somewhat guessable, but for now, it's always > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx