From: Jeff Layton Subject: Re: [PATCH] cifs: call strtobool instead of custom implementation Date: Mon, 12 May 2014 10:14:33 -0400 Message-ID: <20140512101433.5b6e971f@poochiereds.net> References: <1398783193-13741-1-git-send-email-andriy.shevchenko@linux.intel.com> <20140512044114.GA19939@leiri.espoo.7ia.org> <20140512064100.5ba419a8@tlielax.poochiereds.net> <20140512132203.GA31367@leiri.espoo.7ia.org> <1399903195.3703.12.camel@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexander Bokovoy , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, Steve French To: Andy Shevchenko Return-path: In-Reply-To: <1399903195.3703.12.camel-XvqNBM/wLWRrdx17CPfAsdBPR1lH4CV8@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Mon, 12 May 2014 16:59:55 +0300 Andy Shevchenko wrote: > On Mon, 2014-05-12 at 16:22 +0300, Alexander Bokovoy wrote: > > On Mon, May 12, 2014 at 06:41:00AM -0400, Jeff Layton wrote: > > > > This changes the returned value of cifs_linux_ext_proc_write() to > > > > -EINVAL if strtobool() was not able to find a boolean value. > > > > Previously setting anything non-bool wouldn't cause this side-effect. > > > > > > > > Steve, is it OK to you? This is certainly a visible change in that > > > > writing to a proc entry will cause user-space error where it was > > > > ignored before. > > > > > > > > > > I think returning an error there is the right thing to do. If someone > > > is writing to this file, they likely mean for it to have some sort of > > > an effect. > > > > > > Honestly though, the *best* thing would be to (gradually) convert these > > > procfile switches into module options. The way it stands now, it's > > > really hard to set these at boot time. You have to: > > > > > > # modprobe cifs > > > # echo N > /proc/fs/cifs/LinuxExtensionsEnabled > > > # mount -t cifs ... > > > > > > Making sure that gets done for anything in /etc/fstab is...tricky. > > > > > > What would be best is to add module options that affect these > > > variables that could be set via /etc/modprobe.d. > > > > > > Then, either add a warning printk when someone writes to these files > > > that they'll soon be deprecated (in 2-3 releases), or maybe turn them > > > into symlinks that point to the files under /sys/module/cifs/parameters. > > I agree. > > > > I think strtobool() patches are fine (+ change to the commit message). > > I will resend v2 soon. Could I add your Acked-by or Reviewed-by? > Sure, you can add mine... > > The change to module options should certainly be done in a separate > > patchset. > > > > Agreed. -- Jeff