From: Daniel Vetter Subject: Re: [PATCH 4/4] drm/i915: Move the drm_vblank_on() calls to intel_crtc_enable_planes() Date: Mon, 12 May 2014 18:46:34 +0200 Message-ID: <20140512164634.GO25056@phenom.ffwll.local> References: <1399566196-25086-1-git-send-email-ville.syrjala@linux.intel.com> <1399566196-25086-5-git-send-email-ville.syrjala@linux.intel.com> <20140509055324.GF3443@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id C9FDD6E73D for ; Mon, 12 May 2014 09:46:38 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id e51so4976785eek.9 for ; Mon, 12 May 2014 09:46:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140509055324.GF3443@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, May 09, 2014 at 06:53:24AM +0100, Chris Wilson wrote: > On Thu, May 08, 2014 at 07:23:16PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > We always enable vblank interrupts after the planes so move the call > > into intel_crtc_enable_planes(). Later we will reorder the plane vs. > > vblank enable/disable to allow vblank interrupts while the planes are > > getting configured. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > Reviewed-by: Chris Wilson I've dug myself a conflict hell grave by stalling on the core vblank rework stuff too long ... Working on that now. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch