From: Daniel Vetter Subject: Re: [PATCH 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms Date: Tue, 13 May 2014 11:02:40 +0200 Message-ID: <20140513090240.GN25056@phenom.ffwll.local> References: <1399566196-25086-1-git-send-email-ville.syrjala@linux.intel.com> <1399566196-25086-4-git-send-email-ville.syrjala@linux.intel.com> <20140509060309.GH3443@nuc-i3427.alporthouse.com> <20140509090946.GS18465@intel.com> <20140513082834.GE7239@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FF086E5F9 for ; Tue, 13 May 2014 02:02:44 -0700 (PDT) Received: by mail-wg0-f41.google.com with SMTP id z12so50128wgg.12 for ; Tue, 13 May 2014 02:02:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140513082834.GE7239@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 13, 2014 at 09:28:34AM +0100, Chris Wilson wrote: > On Fri, May 09, 2014 at 12:09:46PM +0300, Ville Syrj=E4l=E4 wrote: > > On Fri, May 09, 2014 at 07:03:09AM +0100, Chris Wilson wrote: > > > On Thu, May 08, 2014 at 07:23:15PM +0300, ville.syrjala@linux.intel.c= om wrote: > > > > From: Ville Syrj=E4l=E4 > > > > = > > > > The pipe might not start to actually run until the port has been en= abled > > > > (depends on the platform and port type). So don't try to wait for v= blank > > > > after we enabled the pipe but haven't yet enabled the port. > > > = > > > I am pretty sure those waits were in the docs. Pretty sure, not certa= in > > > though. > > = > > I didn't find them anywhere. The only vblank waits I see are the ones > > for gen2 between disabling the planes and the pipe since the pipe > > disable isn't double buffered on vblank. And that wait is still there > > due to intel_disable_primary_hw_plane(). If my mmio vs. CS flip race > > series ever gets reviewed that also gets killed, but I do add back an > > explicit vblank wait for gen2 only into i9xx_crtc_disable(). > = > Right, there is only the explicit wait required for the panel scaler, as > that more or less requires a sequence of writes to the double-buffered > registers. Otherwise, the waits I remember are just warning that the > register updates are double-buffered. So removing the waits for the pipe > on seems a resonable thing. > = > In the event that we enable then disable the pipe all within a single > frame (i.e. before the enable register updates are written) this should > still work as the next register update will take the disable values for > the current request. I.e. I don't think we need to insert explicit waits > between enable/disabled. > = > Reviewed-by: Chris Wilson Merged patches 2&3, thanks. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch