From: Daniel Vetter Subject: Re: [PATCH] drm/i915/vlv: don't wait for vblank after pipe enable Date: Tue, 13 May 2014 17:14:04 +0200 Message-ID: <20140513151404.GL3908@phenom.ffwll.local> References: <1399934249-6771-1-git-send-email-jbarnes@virtuousgeek.org> <20140513075757.78690f42@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 39A266EAF7 for ; Tue, 13 May 2014 08:14:09 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id c41so517662eek.31 for ; Tue, 13 May 2014 08:14:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140513075757.78690f42@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, May 13, 2014 at 07:57:57AM -0700, Jesse Barnes wrote: > On Tue, 13 May 2014 08:08:55 +0200 > Daniel Vetter wrote: > > > On Tue, May 13, 2014 at 12:37 AM, Jesse Barnes wrote: > > > Like on ILK, the pipe won't be running until later on. > > > > Like on ilk?! Since when is vlv display derived from that? "[PATCH > > 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms" > > from Ville makes a more consistent impression to me. Also, and > > Yeah that's fine too. But of course BYT isn't just i915 legacy; it > also includes some IBX logic on the port side. So you can't just lump > it in with i9xx all the time unfortuantely. Either way it looks like > Ville's patch will fix this too. Hm, I've thought the dp/hdmi ports are from g4x and the pll stuff from the cedarview ... it's a frankenstein for sure ;-) > > Bugzilla: tags for this one? > > Meh, this particular one only addresses an internal bug, and it looks > like Ville didn't include a bz link either... did you add it when you > committed? > > https://bugs.freedesktop.org/show_bug.cgi?id=77297 looks like the closest. Yeah, looks like a match, I'll add it. Although the bug also refers to pch-split platforms ... I'll ask for retesting overall. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch