From: Daniel Vetter Subject: Re: [PATCH 4/5] drm/i915: Use ilk_wm_max_level() in latency debugfs files Date: Tue, 13 May 2014 18:46:23 +0200 Message-ID: <20140513164623.GP3908@phenom.ffwll.local> References: <1399991428-32763-1-git-send-email-damien.lespiau@intel.com> <1399991428-32763-5-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id D1E106EB56 for ; Tue, 13 May 2014 09:46:27 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id e51so618583eek.9 for ; Tue, 13 May 2014 09:46:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1399991428-32763-5-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 13, 2014 at 03:30:27PM +0100, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau I prefer "expose foo" and "use foo" in the same patch. I'll squash these two if you're ok. -Daniel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 18b3565..6801987 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -3084,7 +3084,7 @@ static const struct file_operations i915_display_crc_ctl_fops = { > static void wm_latency_show(struct seq_file *m, const uint16_t wm[5]) > { > struct drm_device *dev = m->private; > - int num_levels = IS_HASWELL(dev) || IS_BROADWELL(dev) ? 5 : 4; > + int num_levels = ilk_wm_max_level(dev) + 1; > int level; > > drm_modeset_lock_all(dev); > @@ -3167,7 +3167,7 @@ static ssize_t wm_latency_write(struct file *file, const char __user *ubuf, > struct seq_file *m = file->private_data; > struct drm_device *dev = m->private; > uint16_t new[5] = { 0 }; > - int num_levels = IS_HASWELL(dev) || IS_BROADWELL(dev) ? 5 : 4; > + int num_levels = ilk_wm_max_level(dev) + 1; > int level; > int ret; > char tmp[32]; > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch