From: Daniel Vetter Subject: Re: [PATCH 4/5] drm/i915: Use ilk_wm_max_level() in latency debugfs files Date: Tue, 13 May 2014 20:03:25 +0200 Message-ID: <20140513180324.GU3908@phenom.ffwll.local> References: <1399991428-32763-1-git-send-email-damien.lespiau@intel.com> <1399991428-32763-5-git-send-email-damien.lespiau@intel.com> <20140513164623.GP3908@phenom.ffwll.local> <20140513165145.GB16632@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id A59B36E322 for ; Tue, 13 May 2014 11:03:29 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id d17so669543eek.2 for ; Tue, 13 May 2014 11:03:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140513165145.GB16632@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 13, 2014 at 05:51:45PM +0100, Damien Lespiau wrote: > On Tue, May 13, 2014 at 06:46:23PM +0200, Daniel Vetter wrote: > > On Tue, May 13, 2014 at 03:30:27PM +0100, Damien Lespiau wrote: > > > Signed-off-by: Damien Lespiau > > > > I prefer "expose foo" and "use foo" in the same patch. I'll squash these > > two if you're ok. > > Sure, no problem. There have been a lot of these in the past, so I was > just assuming that was the unspoken way of doing it. I sure don't mind > either way. Hm, I guess I'm not super-consistent with my bikesheds, but generally I prefer this stuff squashed. Exception is patches to add piles of registers to i915_reg.h, imo for those it makes sense to keep them separate. That helps in review since the grunk work of double-checking Bspec is separate from the more behavioural review of the actual code. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch