From: "Luis R. Rodriguez" Subject: Re: [PATCH v4 11/15] autoconf: xen: move standard variables to a generic place Date: Wed, 14 May 2014 01:03:27 +0200 Message-ID: <20140513230327.GI13289@wotan.suse.de> References: <1398820328-15132-1-git-send-email-mcgrof@do-not-panic.com> <1398820328-15132-12-git-send-email-mcgrof@do-not-panic.com> <5360B9CB020000780000D9BB@suse.com> <20140430175330.GI11838@wotan.suse.de> <53636F9E020000780000E588@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WkLjP-0007jA-HS for xen-devel@lists.xenproject.org; Tue, 13 May 2014 23:03:31 +0000 Content-Disposition: inline In-Reply-To: <53636F9E020000780000E588@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Ian Campbell , "Luis R. Rodriguez" , Tim Deegan , Ian Jackson , xen-devel@lists.xenproject.org, Samuel Thibault List-Id: xen-devel@lists.xenproject.org On Fri, May 02, 2014 at 09:12:46AM +0100, Jan Beulich wrote: > >>> On 30.04.14 at 19:53, wrote: > > On Wed, Apr 30, 2014 at 12:52:27AM -0600, Jan Beulich wrote: > >> >>> On 30.04.14 at 03:12, wrote: > >> > This moves all generic variables to the top level makefile, > >> > tons of files use these so just make them general enough. This > >> > also paves the way to let us easily dynamically configure these > >> > with autoconf, for now we leave the same presets as was present > >> > before. > >> > >> Am I right understanding that this then will require ./configure to > >> be run even for hypervisor-only building? > > > > Its unclear what you mean by that, can you describe what is required > > to accomplish this on a fresh git tree. Can you describe what expectations > > you have on build time to see if this patch breaks that and if so see > > what can be done to avoid this? All the changes I did here really was > > to toss around variables to be set through autoconf and if building > > the hypervisor requries them then yes, but fixing that should be as > > easy as adding schecks to add sensible defaults if configure has not > > been run. > > The main problem I see is with config/StdGNU.mk now including > config/Toplevel.mk, with the latter only being generated by the > configure process. What I expect to continue to work is "make xen" > (and - hopefully unaffected, albeit I didn't check - > "make -C extras/mini-os") without anything else done on a fresh > tree. OK thanks, I've addressed this by not requiring that file but also providing defaults that the system can override once configure is used. Will roll it into my series. Luis