From: Damien Lespiau Subject: Re: [PATCH 1/2] drm/i915: add render state initialization Date: Wed, 14 May 2014 17:37:39 +0100 Message-ID: <20140514163739.GE4835@strange.amr.corp.intel.com> References: <1400076137-16162-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DF7C6E0F5 for ; Wed, 14 May 2014 09:37:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1400076137-16162-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi, kristen@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org On Wed, May 14, 2014 at 05:02:16PM +0300, Mika Kuoppala wrote: > HW guys say that it is not a cool idea to let device > go into rc6 without proper 3d pipeline state. > > For each new uninitialized context, generate a > valid null render state to be run on context > creation. > > This patch introduces a skeleton with empty states. > > v2: - No need to vmap (Chris Wilson) > - use .c files for state (Daniel Vetter) > - no need to flush as i915_add_request does it > - remove parameter for batch alloc size > - don't wait for the init (Ben Widawsky) > > v3: - move to cpu/gpu (Chris Wilson) > > Tested-by: Kristen Carlson Accardi (v1) > Tested-by: Oscar Mateo > Acked-by: Damien Lespiau This one can be upgraded to a: Reviewed-by: Damien Lespiau -- Damien