From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: add render state initialization Date: Wed, 14 May 2014 19:17:24 +0200 Message-ID: <20140514171724.GJ8790@phenom.ffwll.local> References: <1400076137-16162-1-git-send-email-mika.kuoppala@intel.com> <20140514163739.GE4835@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com [74.125.83.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 91AC56E01E for ; Wed, 14 May 2014 10:17:29 -0700 (PDT) Received: by mail-ee0-f48.google.com with SMTP id e49so1572671eek.7 for ; Wed, 14 May 2014 10:17:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140514163739.GE4835@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi, kristen@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org On Wed, May 14, 2014 at 05:37:39PM +0100, Damien Lespiau wrote: > On Wed, May 14, 2014 at 05:02:16PM +0300, Mika Kuoppala wrote: > > HW guys say that it is not a cool idea to let device > > go into rc6 without proper 3d pipeline state. > > > > For each new uninitialized context, generate a > > valid null render state to be run on context > > creation. > > > > This patch introduces a skeleton with empty states. > > > > v2: - No need to vmap (Chris Wilson) > > - use .c files for state (Daniel Vetter) > > - no need to flush as i915_add_request does it > > - remove parameter for batch alloc size > > - don't wait for the init (Ben Widawsky) > > > > v3: - move to cpu/gpu (Chris Wilson) > > > > Tested-by: Kristen Carlson Accardi (v1) > > Tested-by: Oscar Mateo > > Acked-by: Damien Lespiau > > This one can be upgraded to a: > > Reviewed-by: Damien Lespiau Both patches merged, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch