From: Daniel Vetter Subject: Re: [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables Date: Fri, 16 May 2014 17:07:24 +0200 Message-ID: <20140516150724.GM8790@phenom.ffwll.local> References: <1399405683-27409-1-git-send-email-abdiel.janulgue@linux.intel.com> <1399405683-27409-2-git-send-email-abdiel.janulgue@linux.intel.com> <20140507114931.GG18465@intel.com> <3751304.js4FzVGZxl@abj-desktop> <20140508095447.GO18465@intel.com> <20140508101840.GP18465@intel.com> <20140512164043.GL25056@phenom.ffwll.local> <20140516113609.GD3473@nuc-i3427.alporthouse.com> <20140516142734.GK8790@phenom.ffwll.local> <20140516144524.GF3473@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id A84696EF93 for ; Fri, 16 May 2014 08:07:29 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id c13so1651029eek.20 for ; Fri, 16 May 2014 08:07:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140516144524.GF3473@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, May 16, 2014 at 03:45:24PM +0100, Chris Wilson wrote: > On Fri, May 16, 2014 at 04:27:34PM +0200, Daniel Vetter wrote: > > On Fri, May 16, 2014 at 12:36:09PM +0100, Chris Wilson wrote: > > > On Mon, May 12, 2014 at 06:40:43PM +0200, Daniel Vetter wrote: > > > > I think as soon as we have the golden context stuff from Mika we could > > > > drop our usage of restore_inhibit. We only need that to avoid the hw > > > > getting angry if the context state is illegal afaik. > > > > > > Apart from the contexts being over 100x larger than the state required > > > to switch between clients, and that the current code regressed to always > > > update the context between every batch. > > > > We still have the from == to early return in do_switch. That doesn't do > > what it should any more? > > No. > > commit 0009e46cd54324c4af20b0b52b89973b1b914167 > Author: Ben Widawsky > Date: Fri Dec 6 14:11:02 2013 -0800 > > drm/i915: Track which ring a context ran on > > Previously we dropped the association of a context to a ring. It is > however very important to know which ring a context ran on (we could > have reused the other member, but I was nitpicky). > > This is very important when we switch address spaces, which unlike > context objects, do change per ring. > > As an example, if we have: > > RCS BCS > ctx A > ctx A > ctx B > ctx B > > Without tracking the last ring B ran on, we wouldn't know to switch the > address space on BCS in the last row. > > As a result, we no longer need to track which ring a context "belongs" > to, as it never really made much sense anyway. > > Signed-off-by: Ben Widawsky > Signed-off-by: Daniel Vetter > > was just baloney. Oh, totally forgotten about that fun. I'll add it as a new subtask to the big full ppgtt jira :( Thanks digging this out again. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch