From: Thomas Petazzoni Date: Mon, 19 May 2014 13:10:33 +0200 Subject: [Buildroot] [PATCH v2 0/3] Adding support for graphite to buildroot gcc toolchain In-Reply-To: References: Message-ID: <20140519131033.2c6071cf@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Steve Thomas, On Mon, 19 May 2014 10:09:06 +0000, Steve Thomas wrote: > Thanks for pointing me to the buildroot patch submission site. Lets try again :) Looks better, thanks. Though there is still one weird thing: normally git format-patch/send-email make the patch e-mails answers to the cover letter e-mail, so that they nicely appear as threaded. Also, you still haven't taken into account the comments I made on your first version. Can you look at the entire e-mails http://lists.busybox.net/pipermail/buildroot/2014-May/096954.html and http://lists.busybox.net/pipermail/buildroot/2014-May/096955.html ? I suspect you overlooked the comments I made inline, in the various parts of your patch. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com