From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Add MIPI mmio reg base Date: Mon, 19 May 2014 17:57:20 +0200 Message-ID: <20140519155720.GX8790@phenom.ffwll.local> References: <1400513044-7968-1-git-send-email-shashank.sharma@intel.com> <1400513044-7968-2-git-send-email-shashank.sharma@intel.com> <20140519154526.GA19476@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D1606E086 for ; Mon, 19 May 2014 08:57:24 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id d17so3795261eek.30 for ; Mon, 19 May 2014 08:57:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140519154526.GA19476@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, May 19, 2014 at 04:45:26PM +0100, Damien Lespiau wrote: > On Mon, May 19, 2014 at 08:54:03PM +0530, Shashank Sharma wrote: > > This patch adds a mmio base address variable for DSI display, > > to make the DSI code generic, so that, if required, the same code > > can be re-used for future platforms with different mmio base. > > > > Signed-off-by: Shashank Sharma > > The error message is really a programming error, ie if we hit this > error, the the code itself is doing something it shouldn't be doing. > > This is to be compared to an error caused by external factors. > > For that reason, I'd use BUG() here, but I'm not sure that's something > we've clearly defined. > > Also the error message is not super clear and uses Mipi instead of MIPI, > we always captalize it elsewhere. > > Depending on how much bikesheddy other peole are: You might want to add some checkpatch bikesheds, but I've fixed them up while applying. > > Reviewed-by: Damien Lespiau Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch