From: Jesse Barnes Subject: Re: [PATCH 1/2] drm/i915: add stepping macro Date: Wed, 21 May 2014 12:43:55 -0700 Message-ID: <20140521124355.511419f4@jbarnes-desktop> References: <1400697746-7511-1-git-send-email-jbarnes@virtuousgeek.org> <20140521185053.GB12436@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by gabe.freedesktop.org (Postfix) with SMTP id 0C1816E1CF for ; Wed, 21 May 2014 12:43:57 -0700 (PDT) In-Reply-To: <20140521185053.GB12436@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 21 May 2014 19:50:53 +0100 Chris Wilson wrote: > On Wed, May 21, 2014 at 11:42:25AM -0700, Jesse Barnes wrote: > > In some cases to enable or disable features & workarounds, we may need > > to check the GPU stepping. Add a macro to do that based on caching the > > PCI revision ID reg. > > What about just using dev->pdev->revision like we already do? Oh missed that, was looking for stepping comments and didn't see it. Yeah that's fine. -- Jesse Barnes, Intel Open Source Technology Center