From: Damien Lespiau Subject: Re: [PATCH 2/2] drm/i915: Change Mipi register definitions Date: Wed, 21 May 2014 16:49:51 +0100 Message-ID: <20140521154951.GE23160@strange.amr.corp.intel.com> References: <20140519161050.GB19476@strange.amr.corp.intel.com> <1400686019-29933-1-git-send-email-shashank.sharma@intel.com> <20140521153512.GR27580@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 94D4A6E35A for ; Wed, 21 May 2014 08:56:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140521153512.GR27580@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: jani.nikula@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, May 21, 2014 at 06:35:12PM +0300, Ville Syrj=E4l=E4 wrote: > > + > > +/* VLV port control */ > > #define _MIPIA_PORT_CTRL (VLV_DISPLAY_BASE + 0x61190) > > #define _MIPIB_PORT_CTRL (VLV_DISPLAY_BASE + 0x61700) > > #define MIPI_PORT_CTRL(pipe) _PIPE(pipe, _MIPIA_PORT_CTRL, _MIPIB_POR= T_CTRL) > = > Why isn't mipi_mmio_base used here? Does the register not need the new > offset? I htink it would still be cleaner to use the mipi_mmio_offset > for all the MIPI registers. On VLV, this register (a at least one other) isn't part of the MIPI IP block address space (base + 0xbxxx) so shouldn't be defined as mipi_mmio_base + offset. -- = Damien