From: Daniel Vetter Subject: Re: [PATCH v8 3/9] drm/i915: Make sprite updates atomic Date: Thu, 22 May 2014 15:03:56 +0200 Message-ID: <20140522130355.GT14357@phenom.ffwll.local> References: <1398767752-619-1-git-send-email-ville.syrjala@linux.intel.com> <1398767752-619-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id B2C8A6E4A7 for ; Thu, 22 May 2014 06:04:00 -0700 (PDT) Received: by mail-wg0-f46.google.com with SMTP id n12so3375900wgh.29 for ; Thu, 22 May 2014 06:03:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1398767752-619-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 29, 2014 at 01:35:46PM +0300, ville.syrjala@linux.intel.com wrote: > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 96ae78d..d8b540b 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -401,6 +401,8 @@ struct intel_crtc { > /* watermarks currently being used */ > struct intel_pipe_wm active; > } wm; > + > + wait_queue_head_t vbl_wait; > }; A bit late, but found something: Why can't we use dev->vblank[crtc].queue here? We reuse all the vblank infrastructure already ... If you want pretty just add a tiny helper function wait_queue_head_t *drm_crtc_vblank_waitqueue(struct drm_crtc *crtc) { return &dev->vblank[drm_crtc_index(crtc)].queue; } somewhere. I feel guilty here since I've killed Akash's patch over adding a new vblank wait queue and let yours slip through ;-) Can you please take care of this? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch