From: Stephen Hemminger Subject: Re: [PATCH iproute2 v3] fq: allow options of fair queue set to ~0U Date: Wed, 28 May 2014 17:09:57 -0700 Message-ID: <20140528170957.19b50c12@nehalam.linuxnetplumber.net> References: <1399868319-2184-1-git-send-email-yangyingliang@huawei.com> <1399874336.7973.17.camel@edumazet-glaptop2.roam.corp.google.com> <5370713F.7040701@huawei.com> <1399908225.7973.25.camel@edumazet-glaptop2.roam.corp.google.com> <53718221.6040909@huawei.com> <53719DA4.1010300@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , To: Yang Yingliang Return-path: Received: from mail-pb0-f44.google.com ([209.85.160.44]:56231 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753955AbaE2AKB (ORCPT ); Wed, 28 May 2014 20:10:01 -0400 Received: by mail-pb0-f44.google.com with SMTP id rq2so12013868pbb.17 for ; Wed, 28 May 2014 17:10:01 -0700 (PDT) In-Reply-To: <53719DA4.1010300@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 13 May 2014 12:20:52 +0800 Yang Yingliang wrote: > + int set_plimit = 0; > + int set_flow_plimit = 0; > + int set_quantum = 0; > + int set_initial_quantum = 0; > + int set_maxrate = 0; > + int set_defrate = 0; Please use bool for these since they are boolean flags.