From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: tell the user if both KMS and UMS are disabled Date: Mon, 2 Jun 2014 17:31:04 +0200 Message-ID: <20140602153104.GW19050@phenom.ffwll.local> References: <20140527171923.GI14841@phenom.ffwll.local> <1401717510-21921-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id CD7046E5AD for ; Mon, 2 Jun 2014 08:31:11 -0700 (PDT) Received: by mail-wg0-f43.google.com with SMTP id l18so5342316wgh.14 for ; Mon, 02 Jun 2014 08:31:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1401717510-21921-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jun 02, 2014 at 04:58:30PM +0300, Jani Nikula wrote: > If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and > UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might > not be aware his setup is not supported. Inform the users (and, by > extension, the poor i915 developers having to read their dmesgs in bug > reports) why their graphics experience might be lacking. > > A similar message was added on the UMS path in > commit e147accbd19f55489dabdcc4dc3551cc3e3f2553 > Author: Jani Nikula > Date: Thu Oct 10 15:25:37 2013 +0300 > > drm/i915: tell the user KMS is required for gen6+ > > but it won't be reached if CONFIG_DRM_I915_UMS=n since > commit b30324adaf8d2e5950a602bde63030d15a61826f > Author: Daniel Vetter > Date: Wed Nov 13 22:11:25 2013 +0100 > > drm/i915: Deprecated UMS support > > v2: Use DRM_DEBUG_DRIVER. > > Signed-off-by: Jani Nikula Queued for -next, thanks for the patch. I'll shuffle it into the 3.16 pile when I get around to that. -Daniel > --- > drivers/gpu/drm/i915/i915_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index b6d2a8f96278..8e58083ffb11 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1576,6 +1576,7 @@ static int __init i915_init(void) > driver.get_vblank_timestamp = NULL; > #ifndef CONFIG_DRM_I915_UMS > /* Silently fail loading to not upset userspace. */ > + DRM_DEBUG_DRIVER("KMS and UMS disabled.\n"); > return 0; > #endif > } > -- > 1.9.1 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch