From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Print PCI revision in i915_dump_device_info() Date: Fri, 13 Jun 2014 16:03:17 +0200 Message-ID: <20140613140317.GM5821@phenom.ffwll.local> References: <1402663196-21702-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTP id B9F2D6EA27 for ; Fri, 13 Jun 2014 07:03:25 -0700 (PDT) Received: by mail-wi0-f180.google.com with SMTP id hi2so947220wib.7 for ; Fri, 13 Jun 2014 07:03:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1402663196-21702-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jun 13, 2014 at 03:39:56PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > Knowing the device stepping may be crucial in analyzing problems. Since > we always ask bug reporters for dmegs with drm.debug=3D0xe (or something) > it would be nice if the PCI revision is already included in the dump. > Avoids having to ask for lspci output as well. > = > Signed-off-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_dma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_= dma.c > index 7c63b18..aadb0c9 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1493,10 +1493,11 @@ static void i915_dump_device_info(struct drm_i915= _private *dev_priv) > #define SEP_EMPTY > #define PRINT_FLAG(name) info->name ? #name "," : "" > #define SEP_COMMA , > - DRM_DEBUG_DRIVER("i915 device info: gen=3D%i, pciid=3D0x%04x flags=3D" > + DRM_DEBUG_DRIVER("i915 device info: gen=3D%i, pciid=3D0x%04x rev=3D0x%0= 2x flags=3D" > DEV_INFO_FOR_EACH_FLAG(PRINT_S, SEP_EMPTY), > info->gen, > dev_priv->dev->pdev->device, > + dev_priv->dev->pdev->revision, > DEV_INFO_FOR_EACH_FLAG(PRINT_FLAG, SEP_COMMA)); > #undef PRINT_S > #undef SEP_EMPTY > -- = > 1.8.5.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch