From: Damien Lespiau Subject: Re: [PATCH i-g-t 1/5] kms: Add universal plane support Date: Fri, 13 Jun 2014 18:00:07 +0100 Message-ID: <20140613170006.GU31323@strange.amr.corp.intel.com> References: <1401376014-24845-1-git-send-email-matthew.d.roper@intel.com> <1401376157-24940-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D6596EAB8 for ; Fri, 13 Jun 2014 10:00:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1401376157-24940-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org As a small summary, I don't think we should be exposing the plane_commit() function and always go through igt_display_commit() to make hooking the atomic ioctl() easier. Loosing the plane ordering is a bit meh but should be able to live with it. The rest looks good. -- Damien