From: Jesse Barnes Subject: Re: [PATCH] Fixed the review issues for pm_rc6_residency IGT case Date: Mon, 16 Jun 2014 13:38:22 -0700 Message-ID: <20140616133822.713a7765@jbarnes-desktop> References: <1402303007-25566-1-git-send-email-wendy.wang@intel.com> <20140616184330.GB1718@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 977B96E3B4 for ; Mon, 16 Jun 2014 13:38:05 -0700 (PDT) Received: by mail-pd0-f179.google.com with SMTP id w10so2162253pde.38 for ; Mon, 16 Jun 2014 13:38:05 -0700 (PDT) In-Reply-To: <20140616184330.GB1718@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: Paul Parenteau , intel-gfx@lists.freedesktop.org, lei.a.liu@intel.com, gordon.jin@intel.com List-Id: intel-gfx@lists.freedesktop.org On Mon, 16 Jun 2014 11:43:30 -0700 Ben Widawsky wrote: > Hi Wendy. Daniel has reverted your original commit here: > commit 35554a1bcaaea55c1cfa88c0176c58d2fb3b8013 > Author: Daniel Vetter > Date: Tue Jun 10 11:05:16 2014 +0200 > > Revert "Add rc6_residency_counter subtest" > > Note that I absolutely do not agree with the decision to revert your > patch as was stated in the commit message. I am not sure how Daniel got > the impression that I thought this was "in order." > > Can you please resubmit the patch based on the latest intel-gpu-tools? I also made that clear when Daniel and I discussed it. I simply don't understand why a revert was necessary, especially given that we had an incremental patch to address many of the comments. Was the test breaking i-g-t runs (i.e. preventing tests from running)? Was it somehow crashing and causing false reports? -- Jesse Barnes, Intel Open Source Technology Center