From: Daniel Vetter Subject: Re: [PATCH 00/10] Support for 180 degree HW rotation Date: Wed, 18 Jun 2014 14:37:08 +0200 Message-ID: <20140618123708.GD5821@phenom.ffwll.local> References: <1403091899-5055-1-git-send-email-sonika.jindal@intel.com> <20140618115229.GC5821@phenom.ffwll.local> <53A17EB5.2010207@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 64BD76E58C for ; Wed, 18 Jun 2014 05:37:16 -0700 (PDT) Received: by mail-we0-f181.google.com with SMTP id q59so794239wes.12 for ; Wed, 18 Jun 2014 05:37:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53A17EB5.2010207@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Jindal, Sonika" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 18, 2014 at 05:27:41PM +0530, Jindal, Sonika wrote: > = > = > On 6/18/2014 5:22 PM, Daniel Vetter wrote: > >On Wed, Jun 18, 2014 at 05:14:49PM +0530, sonika.jindal@intel.com wrote: > >>From: Sonika Jindal > >> > >>Enables 180 degree rotation for sprite and primary planes. > >>Updated the primary plane rotation support as per the new universal pla= ne > >>design. > >> > >>Most of these patches were already reviewed in intel-gfx in February 20= 14 thats > >>why there is version history in few of them. > >> > >>Testcase: kms_rotation_crc > >>This igt can be extended for clipped rotation cases. Right it only test= s 180 > >>degree rotation for sprite and primary plane with crc check. > >> > >>Sonika Jindal (1): > >> drm/i915: Add 180 degree primary plane rotation support > >> > >>Ville Syrj=E4l=E4 (9): > >> drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h > >> drm: Add support_bits parameter to drm_property_create_bitmask() > >> drm: Add drm_mode_create_rotation_property() > >> drm/omap: Switch omapdrm over to drm_mode_create_rotation_property() > >> drm: Add drm_rect rotation functions > >> drm: Add drm_rotation_simplify() > >> drm/i915: Add 180 degree sprite rotation support > >> drm/i915: Make intel_plane_restore() return an error > >> drm/i915: Add rotation property for sprites > > > >Pleas don't repost entire patch series on the same day without a changel= og > >in the cover letter explaining what's going on and what changed. > > > >If you just need to repost a few patches that changed due to review, > >please do that with an in-reply-to directly to the relevant discussion. > > > >If everyone reposts their big patch series a few times a day we'll have > >utter chaos. > >-Daniel > = > I am sorry for this. I thought creating a new patchset should be good, > missed updating it in cover letter. > I will keep this in mind. It's always a balancing act - if the threads nest too deeply eventually in-reply-to becomes a mess, too. But a rule of thumb is that you should only resend when the patch series changed completely or once review has settled down (so only after a few days) and the review thread has become too deeply nested. But resending the entire series on the same day before review has concluded is definitely too early. Our team is global so without a full day not everyone even had a chance to look at it - us west coast is still fast asleep ;-) -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch