From: Damien Lespiau Subject: Re: [PATCH 10/11] drm/i915: Add 180 degree primary plane rotation support Date: Thu, 19 Jun 2014 11:07:31 +0100 Message-ID: <20140619100731.GJ18833@strange.amr.corp.intel.com> References: <1403081847-4364-1-git-send-email-sonika.jindal@intel.com> <1403081847-4364-11-git-send-email-sonika.jindal@intel.com> <20140618170248.GF18833@strange.amr.corp.intel.com> <53A286AA.6030204@intel.com> <20140619070700.GO5821@phenom.ffwll.local> <53A296B9.6080506@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B883D88E35 for ; Thu, 19 Jun 2014 03:07:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53A296B9.6080506@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Jindal, Sonika" Cc: intel-gfx@lists.freedesktop.org, "Kamble, Sagar A" List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 19, 2014 at 01:22:25PM +0530, Jindal, Sonika wrote: > >>I see that in omap driver too it is done in lastclose of the driver. Also, > >>from driver fbdev_restore is only called during lastclose. > >>Again I don't have more knowledge on this. > >>Can we keep it here in this lastclose function to comply with omap driver? Just to be thorough, there's an important path that is not from lastclose(): + drm_fb_helper_set_par() + drm_fb_helper_restore_fbdev_mode_unlocked() + restore_fbdev_mode() -- Damien