From: Damien Lespiau Subject: Re: [PATCH 0/3] Moving rotation_property to drm_plane Date: Wed, 2 Jul 2014 14:17:00 +0100 Message-ID: <20140702131700.GG26852@strange.amr.corp.intel.com> References: <20140619082148.GR5821@phenom.ffwll.local> <1403611708-7559-1-git-send-email-sonika.jindal@intel.com> <53B3C828.5010403@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id BC6416E5C4 for ; Wed, 2 Jul 2014 06:17:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53B3C828.5010403@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Jindal, Sonika" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 02, 2014 at 02:21:52PM +0530, Jindal, Sonika wrote: > Hi, > > Did anybody get a chance to review these patches? Ok, now those patches are all over the place. It's pretty much impossible to have the big picture again with the latest changes (the rotation on drm_plane) nor the limit of the the series, esp. as the documentation patches have been split off. I'm not sure why, but it seems like the Cc: tags in your emails have never actually ended up in the Cc: header of your mails. Which means they never hit dri-devel. Can you make sure you fix that for the next resend. This means we haven't gathered their feedback during all this time... What you can do: Use --dry-run to make sure you're sending them the dri-devel. Maybe use the --cc command line option instead? Also, as already mentioned, don't send the patches to the LKML, noone will review them there. Could you resend the full series with the reviewed-by tags gathered so far? with dri-devel in copy? in a separarte mail thread? We usually version the big resend of series in the cover letter, explaning the changes. Thanks, -- Damien