From: "Luis R. Rodriguez" Subject: Re: [PATCH v6 10/13] autoconf: xen: move standard path variables to config/Paths.mk.in Date: Thu, 3 Jul 2014 20:53:43 +0200 Message-ID: <20140703185343.GI27687@wotan.suse.de> References: <1402622331-4282-1-git-send-email-mcgrof@do-not-panic.com> <1402622331-4282-11-git-send-email-mcgrof@do-not-panic.com> <1404308054.5562.82.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X2m8f-0000qk-RT for xen-devel@lists.xenproject.org; Thu, 03 Jul 2014 18:53:45 +0000 Content-Disposition: inline In-Reply-To: <1404308054.5562.82.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Keir Fraser , "Luis R. Rodriguez" , Tim Deegan , Ian Jackson , Jan Beulich , Samuel Thibault , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, Jul 02, 2014 at 02:34:14PM +0100, Ian Campbell wrote: > On Thu, 2014-06-12 at 18:18 -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > +LIBDIR=`eval echo $libdir` > > Why is this one an eval? BTW I now see why I had used the eval on LIBDIR, its because otherwise Paths.mk ends up with: LIBDIR := ${exec_prefix}/lib64 ... PRIVATE_PREFIX := ${exec_prefix}/lib64/xen PRIVATE_PREFIX := ${exec_prefix}/lib64/xen PRIVATE_BINDIR := ${exec_prefix}/lib64/xen/bin ... Can I upkeep the eval? Luis